docs(kubernetes-mcp-server): sync template standards updates#347
Merged
Merged
Conversation
📝 WalkthroughWalkthroughUpdates the kubernetes-mcp-server playground configuration and registry wiring, and refreshes its chart documentation for the new image tag and configuration details. ChangesKubernetes MCP Server updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
mberlofa
force-pushed
the
docs/kubernetes-mcp-server-template-standards-sync
branch
2 times, most recently
from
618fdfa to
f5e8370
Compare
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - align kubernetes-mcp-server template standards: immutable selector labels, guarded ingressClassName, centralized validate helper, and numbered NOTES - add NetworkPolicy egress isolation whenever `networkPolicy.enabled=true`, with built-in DNS and HTTPS allowances plus configurable `networkPolicy.dnsEgressPeers` defaulting to kube-system/kube-dns - keep `networkPolicy.extraEgress` additive for API server or proxy rules, and sync values schema defaults plus unit coverage for selector label overrides, existingClaim scaling, scoped DNS egress, and baseline egress ## Validation - helm template test charts/kubernetes-mcp-server --set networkPolicy.enabled=true --set 'networkPolicy.extraEgress[0].ports[0].port=6443' - helm unittest charts/kubernetes-mcp-server: 20 tests, 7 suites - make template-standards-check CHART=kubernetes-mcp-server - node scripts/charts/validate-chart.js --chart kubernetes-mcp-server --no-k3d - make validate-chart CHART=kubernetes-mcp-server TIMEOUT=900: FULLY VALIDATED (16 layers) - make site-sync-check CHART=kubernetes-mcp-server - make release-check REPO=charts - make attribution-check REPO=charts Issue: #633 Site PR: helmforgedev/site#347 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added `networkPolicy.extraEgress` and `networkPolicy.dnsEgressPeers` to extend/shape egress rules beyond built-in DNS/HTTPS allowances. * **Bug Fixes** * `ingress.ingressClassName` is now rendered only when explicitly set (non-empty). * Aligned pod template labels with the Deployment selector labels. * **Documentation** * Updated chart README and Helm NOTES with expanded production safety, exposure, and troubleshooting guidance; refreshed image tag to `v0.0.63`. * **Tests** * Expanded validation, ingress, and network policy assertions (including egress ordering and appended extra egress rules). <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: MergeCheck <mergecheck@example.invalid>
mberlofa
force-pushed
the
docs/kubernetes-mcp-server-template-standards-sync
branch
from
f5e8370 to
bcf923f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/data/playground-configs.ts (1)
8681-8708: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueSection title doesn't match the API Egress Port field.
The
DNS Egressgroup bundles the unrelatedAPI Egress Port(networkPolicy.extraEgress[0].ports[0].port, default6443) field alongside the DNS namespace/pod selector fields. Since this port targets Kubernetes API access rather than DNS, consider renaming the section (e.g., "Network Egress") or splitting the API port field into its own group for clarity.✏️ Optional rename
{ - name: 'DNS Egress', + name: 'Network Egress', collapsible: true, gateField: 'networkPolicy.enabled',🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/data/playground-configs.ts` around lines 8681 - 8708, The `DNS Egress` group in `playground-configs.ts` mixes DNS selector fields with the unrelated `API Egress Port` field, so update the section structure around the `fields` array for that group. Either rename the group to something broader like “Network Egress” or move `networkPolicy.extraEgress[0].ports[0].port` into its own separate section, keeping the DNS-related fields under `DNS Egress` only.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/data/playground-configs.ts`:
- Around line 8681-8708: The `DNS Egress` group in `playground-configs.ts` mixes
DNS selector fields with the unrelated `API Egress Port` field, so update the
section structure around the `fields` array for that group. Either rename the
group to something broader like “Network Egress” or move
`networkPolicy.extraEgress[0].ports[0].port` into its own separate section,
keeping the DNS-related fields under `DNS Egress` only.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 911fc5a5-4e28-4e7b-b013-7432b7be2dab
📒 Files selected for processing (3)
src/data/playground-configs.tssrc/pages/docs/charts/kubernetes-mcp-server.mdxsrc/pages/playground.astro
✅ Files skipped from review due to trivial changes (1)
- src/pages/docs/charts/kubernetes-mcp-server.mdx
🚧 Files skipped from review as they are similar to previous changes (1)
- src/pages/playground.astro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networkPolicy.enabledbaseline DNS/HTTPS egress, configurablenetworkPolicy.dnsEgressPeers, and additivenetworkPolicy.extraEgressbehaviorValidation
Chart PR: helmforgedev/charts#669
Issue: helmforgedev/charts#633
Summary by CodeRabbit
New Features
Documentation